Opened 8 years ago

Closed 8 years ago

#725 closed defect (fixed)

Drop regex dependencies from chicken-core scripts

Reported by: Mario Domenech Goulart Owned by: felix winkelmann
Priority: not urgent at all Milestone:
Component: core tools Version: 4.7.x
Keywords: regex, core scripts Cc:
Estimated difficulty:

Description

Make the following scripts use irregex instead of regex:

  • dpkg-eggs.scm
  • make-eggdoc.scm
  • wiki2html.scm
  • tools.scm

(are they even used?)

Attachments (1)

0001-Remove-unneeded-dependencies-on-regex-in-scripts-725.patch (1.3 KB) - added by Jim Ursetto 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by felix winkelmann

Owner: set to felix winkelmann
Status: newassigned

comment:2 Changed 8 years ago by felix winkelmann

Milestone: 4.8.0

comment:3 Changed 8 years ago by Jim Ursetto

This change appears to be unnecessary.

  • dpkg-eggs.scm -- Claims dependency on regex, but actually has none; (use regex) can be removed.
  • make-eggdoc.scm -- Claims dependency on regex, but actually has none; (use regex) can be removed.
  • tools.scm -- Was already converted to irregex in 8a516a0425.
  • wiki2html.scm -- Also depends on htmlprag and matchable, so converting to irregex gains you nothing except verbosity.

Overall, it seems that (use regex) was added to tools.scm just to provide string-match, but string-match is only used in wiki2html.scm, which already depends on regex.

comment:4 Changed 8 years ago by Mario Domenech Goulart

You are right, Jim. Boy, what a mess I've made!

I have no idea why I thought/saw string-match in tools.scm. I'm really sorry for all the confusion.

comment:5 Changed 8 years ago by Jim Ursetto

Attached will fix by removing unused regex deps. Should I push it myself?

Note that dpkg-eggs.scm is still broken afterward because it uses ##sys#pathname-directory-separator, which no longer exists. It could be changed to make-pathname but it's probably safer for Ivan to fix that (if it is still in use).

comment:6 Changed 8 years ago by felix winkelmann

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.