Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#728 closed defect (fixed)

sendfile.setup will probably not work on windows

Reported by: Mario Domenech Goulart Owned by: certainty
Priority: major Milestone: 4.9.0
Component: extensions Version: 4.7.x
Keywords: sendfile Cc:
Estimated difficulty:

Description

The latest lines from sendfile.setup are

;; cleanup temp-files
;; remove this in production
(system "rm *.o")

I suspect that it'll break the sendfile installation on systems that have no rm (e.g., Windows).

Change History (3)

comment:1 Changed 9 years ago by certainty

Status: newaccepted

Thanks Mario. You are very right. I put it there as a quick fix, that was not supposed to last that long.
I'll take care of it

comment:2 Changed 9 years ago by certainty

Resolution: fixed
Status: acceptedclosed

I've just removed this line, as it's easier to just do it yourself if you don't like it than finding a crossplatform way (which is hard for me to test without a windows) of removing the object files.

comment:3 Changed 8 years ago by felix winkelmann

Milestone: 4.8.04.9.0

Milestone 4.8.0 deleted

Note: See TracTickets for help on using tickets.