Opened 9 years ago

Closed 9 years ago

Last modified 8 years ago

#727 closed defect (fixed)

sendfile broken for files > 1MB

Reported by: Mario Domenech Goulart Owned by: certainty
Priority: critical Milestone: 4.9.0
Component: extensions Version: 4.7.x
Keywords: sendfile Cc:
Estimated difficulty:

Description

Here's the error when using spiffy to serve a file generated with

dd if=/dev/zero of=foo.data bs=1024 count=1025

If the data file is generated with

dd if=/dev/zero of=foo.data bs=1024 count=1024

no error occurs.

Moritz has provided a patch: http://moritz.twoticketsplease.de/files/excellent-sendfile-fix.patch which fixes that.

Change History (3)

comment:1 Changed 9 years ago by certainty

Status: newaccepted

Thanks Moritz. That is a silly bug. I'll apply your patch asap

comment:2 Changed 9 years ago by certainty

Resolution: fixed
Status: acceptedclosed

I've applied the patch and release 1.7.8.
Thanks

comment:3 Changed 8 years ago by felix winkelmann

Milestone: 4.8.04.9.0

Milestone 4.8.0 deleted

Note: See TracTickets for help on using tickets.