Ticket #727 (closed defect: fixed)

Opened 18 months ago

Last modified 8 months ago

sendfile broken for files > 1MB

Reported by: mario Owned by: certainty
Priority: critical Milestone: 4.9.0
Component: extensions Version: 4.7.x
Keywords: sendfile Cc:

Description

Here's the error when using spiffy to serve a file generated with 

dd if=/dev/zero of=foo.data bs=1024 count=1025

If the data file is generated with

dd if=/dev/zero of=foo.data bs=1024 count=1024

no error occurs.

Moritz has provided a patch: http://moritz.twoticketsplease.de/files/excellent-sendfile-fix.patch which fixes that.

Change History

Changed 18 months ago by certainty

  • status changed from new to accepted

Thanks Moritz. That is a silly bug. I'll apply your patch asap

Changed 18 months ago by certainty

  • status changed from accepted to closed
  • resolution set to fixed

I've applied the patch and release 1.7.8.
Thanks

Changed 8 months ago by felix

  • milestone changed from 4.8.0 to 4.9.0

Milestone 4.8.0 deleted

Note: See TracTickets for help on using tickets.