Opened 14 years ago

Closed 12 years ago

#427 closed defect (fixed)

salmonella does not report errors in .meta files.

Reported by: Alan Post Owned by:
Priority: minor Milestone:
Component: infrastructure Version: 4.6.x
Keywords: salmonella Cc:
Estimated difficulty:

Description

I had a bug in my kiksispehi egg, which I fixed in r21262. This bug was a syntax error in my .meta file.

Before this fix, salmonella did not report an error in this package, it treated the egg as if it did not exist. I'm not sure if this was because there were no other files in the egg directory, but this *was* the case for this error.

I believe a syntax error in an egg's .meta file should be flagged as an error, just as a missing .setup file is reported:

http://tests.call-cc.org/2010/11/03/salmonella-report/jbogenturfahi.html

Change History (3)

comment:1 Changed 14 years ago by Mario Domenech Goulart

Salmonella uses setup-download's gather-egg-information to find out information about eggs. I suppose gather-egg-information just ignores eggs which have syntax errors in their .meta files, since they can't be read.

So, since gather-egg-information doesn't tell salmonella about the existence of eggs, salmonella doesn't have a way to know whether they exist or not.

comment:2 Changed 14 years ago by felix winkelmann

Milestone: 4.7.0

comment:3 Changed 12 years ago by Mario Domenech Goulart

Resolution: fixed
Status: newclosed

A new salmonella has been installed on tests.call-cc.org (a rewrite). The old one is obsolete. The new one should be able to catch malformed .meta files. I'm closing this ticket as "fixed" just because there is not "probably fixed" option.

Note: See TracTickets for help on using tickets.