Opened 8 years ago

Closed 8 years ago

#978 closed defect (fixed)

Ports don't keep track of "column" anymore - restore this

Reported by: sjamaan Owned by: sjamaan
Priority: not urgent at all Milestone: someday
Component: core libraries Version: 4.8.x
Keywords: ports, position Cc:
Estimated difficulty:

Description

Slot 5 is no longer being updated by any port procedure except read-char. This causes port-position to return useless values.

This should be restored for read-line and friends.

Attachments (1)

0002-Also-add-column-row-counting-to-read-string.patch (1.5 KB) - added by Jim Ursetto 8 years ago.

Download all attachments as: .zip

Change History (3)

comment:1 Changed 8 years ago by Jim Ursetto

Milestone: 4.9.0someday
Priority: minornot urgent at all

read-line is fixed in a302a6dcc9 per Peter's patch. I also added some tests for the affected ports.

I think we can leave read-string alone -- if you care about lines, you're probably using read-char or read-line anyway. I'm attaching Peter's read-string patch to the ticket for posterity, but I recommend we leave it alone until someone complains.

comment:2 Changed 8 years ago by sjamaan

Resolution: fixed
Status: newclosed

I think the fix for this ticket is acceptable. There's no reason to keep it open; the attached fix for read-string can hopefully be found when we need it, or else we can always write it again from scratch.

Note: See TracTickets for help on using tickets.