Opened 10 years ago

Closed 9 years ago

#947 closed enhancement (fixed)

make: phony support

Reported by: Mario Domenech Goulart Owned by: felix winkelmann
Priority: minor Milestone: someday
Component: extensions Version: 4.8.x
Keywords: make, phony Cc:
Estimated difficulty:

Description

While using the make egg on a project, I needed to create rules whose targets are just labels, not files (like make's PHONY).

I ended up modifying the make egg to be able to do that. If the patch doesn't look too ugly, can you consider applying it? Feel free to change the parameter name.

Attachments (1)

phony.diff (2.2 KB) - added by Mario Domenech Goulart 10 years ago.
Fixed patch

Download all attachments as: .zip

Change History (6)

comment:1 Changed 10 years ago by Mario Domenech Goulart

Hold on. That patch is not right.

Changed 10 years ago by Mario Domenech Goulart

Attachment: phony.diff added

Fixed patch

comment:2 Changed 10 years ago by Mario Domenech Goulart

Alright. The new one (overwrote the old one) should be better (I hope). It also fixes some typos (s/dependancy/dependency/).

comment:3 Changed 10 years ago by felix winkelmann

Thanks - I'll apply this as soon as I find the time. Sorry for the delay.

comment:4 Changed 9 years ago by Mario Domenech Goulart

Does the patch look ok? If so, I can tag a new release. If it doesn't look ok, I can try to improve it or come up with a workaround for my use case.

comment:5 Changed 9 years ago by felix winkelmann

Resolution: fixed
Status: newclosed

I have tagged a new version with your patch applied. Thanks for the contribution, Mario.

Note: See TracTickets for help on using tickets.