tests that rely on diff break with clang

[Mario Domenech Goulart]

Not a serious problem. clang generates some warnings that are not in the expected output files.

Warnings like:

../chicken.h:2292:1: warning: control may reach end of non-void function [-Wreturn-type]
}
^
../chicken.h:2299:1: warning: control may reach end of non-void function [-Wreturn-type]
}
^
../chicken.h:2336:1: warning: control may reach end of non-void function [-Wreturn-type]
}
^
../chicken.h:2344:1: warning: control may reach end of non-void function [-Wreturn-type]
}
^
4 warnings generated.

[Jim Ursetto]

Not positive offhand, but IIRC this is because I had to remove "attribute noreturn" because clang was complaining about it. In terms of functionality it's ok but it is still suboptimal.

[Mario Domenech Goulart]

Patch submitted to chicken-hackers

[Jim Ursetto]

The actual cause of this is the introduction of C_div_by_zero_error followed by an else clause in 4 places. Although legal with the noret attribute, I think it's cleaner (and silences the warnings even without noret) to remove the else. Patch attached.

[Jim Ursetto]

That's not to say the noret patch is not necessary -- it is, and we should leave this ticket open for it -- but in the meantime, my patch is simple and kills a lot of compiler noise, without worrying about clang version.

[Jim Ursetto]

Was fixed in f89c875 (C_div_by_zero patch) prior to 4.8.0 release.