Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#729 closed defect (fixed)

sendfile test errors

Reported by: Mario Domenech Goulart Owned by: certainty
Priority: critical Milestone: 4.9.0
Component: extensions Version: 4.7.x
Keywords: sendfile Cc:
Estimated difficulty:

Attachments (1)

729-osx.patch (1.1 KB) - added by Jim Ursetto 10 years ago.
Fix corruption on OS X related to EAGAIN

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by Jim Ursetto

Also, sending a file on macosx 64-bit 10.7 with sendfile results in corruption at byte 81661 (I have also seen 83K).

comment:2 Changed 10 years ago by Jim Ursetto

I believe the problem on OS X is that sendfile() will return EAGAIN even if it was able to send partial data; this is then discarded by the implementation, which assumes zero bytes were sent and tries to retransmit the full buffer.

comment:3 Changed 10 years ago by Jim Ursetto

Priority: majorcritical

This patch fixes the corruption on OS X. Use hg import to import it, I do not feel like forking on bitbucket so sue me lolololol

Changed 10 years ago by Jim Ursetto

Attachment: 729-osx.patch added

Fix corruption on OS X related to EAGAIN

comment:4 Changed 10 years ago by certainty

Status: newaccepted

Thanks for reporting this, Jim. There are some tests which fail occasionally as well.
I don't know why yet. I'll happily apply your patch

comment:5 Changed 10 years ago by certainty

Resolution: fixed
Status: acceptedclosed

I've applied the patch to trunk and will soon tag a release

comment:6 Changed 9 years ago by felix winkelmann

Milestone: 4.8.04.9.0

Milestone 4.8.0 deleted

Note: See TracTickets for help on using tickets.