#496 closed defect (wontfix)
shell egg doesn't properly quote command lines
| Reported by: | Moritz Heidkamp | Owned by: | felix winkelmann |
|---|---|---|---|
| Priority: | major | Milestone: | 4.9.0 |
| Component: | extensions | Version: | 4.6.x |
| Keywords: | egg shell | Cc: | |
| Estimated difficulty: |
Description
The shell egg doesn't properly quote command lines. For example
(run ("grep" "foo bar"))
will fail with
grep: bar: No such file or directory
i.e. it passes the single argument as two arguments. The attached patch fixes that by using posix {{process-run}} with a separate argument list and additionally cleans up dependencies and exports.
Attachments (1)
Change History (7)
Changed 13 years ago by
| Attachment: | shell-escaping.patch added |
|---|
comment:1 Changed 13 years ago by
comment:2 follow-up: 3 Changed 13 years ago by
I'm not sure what you mean with argument expansion. Can you give an example?
comment:3 Changed 13 years ago by
Replying to syn:
I'm not sure what you mean with argument expansion. Can you give an example?
Is this passed to the shell or is the process called directly. I assume the latter, which would not be right. The run command does no automatic escaping, use qs for that. In other words, it is known and intended to not escape. Perhaps this should be documented more thoroughly.
comment:4 Changed 13 years ago by
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
But does this allow argument expansion usually done by the shell?