Opened 9 months ago
Last modified 8 months ago
#1832 new defect
Exported syntaxes are not fully hygienic
Reported by: | Dominik Joe Pantůček | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | someday |
Component: | compiler | Version: | 5.3.0 |
Keywords: | syntax hygiene modules | Cc: | |
Estimated difficulty: | hard |
Description
Modules exporting syntaxes generated by syntaxes are not fully hygienic as the serialization into module-name.import.scm uses strip-syntax on module's sexports.
Minimal (Working) Example
Attached as follows:
mwe-ok.scm - single file where the macros show expected behavior
mwe-ko-common.scm - module with the macro generating macros
mwe-ko-one.scm - first macro generated by the macro from common module
mwe-ko-two.scm - second macro generated by the macro from module "one"
mw-ko-run.scm - should behave like mwe-ok.scm, shows binding collisions
How to run
Reference (working) module:
csi -q -b mwe.ok.scm
Multiple modules with problems:
csc -P -J mwe-ko-common.scm csc -P -J mwe-ko-one.scm csc -P -J mwe-ko-two.scm csi -q -b mwe-ko-run.scm
Attachments (5)
Change History (7)
Changed 9 months ago by
Attachment: | mwe-ok.scm added |
---|
Changed 9 months ago by
Attachment: | mwe-ko-common.scm added |
---|
Non-working example, module with base syntax.
Changed 9 months ago by
Attachment: | mwe-ko-one.scm added |
---|
Non-working example, module with first generated syntax.
Changed 9 months ago by
Attachment: | mwe-ko-two.scm added |
---|
Non-working example, module with second generated syntax.
comment:1 follow-up: 2 Changed 8 months ago by
The problem is clearly strip-syntax - that should not be used. It's used because we don't want to emit gensymed names, as those won't be resolvable when loading the import library (that's a different compilation pass, which doesn't have the same aliases database).
A potential solution might involve something akin to canonicalize-expression
on the syntax form, leaving any unresolved symbols as is (so keeping the gensymed aliases in place). There'd still be a risk of capture since those names won't be gensymed anymore, but it'd be less likely since they'd still be obfuscated.
I think if this works, we won't need the eval for the module-import-forms
anymore either, as everything will be fully resolved.
Finally, I think we'd do well to simplify this example a bit. The code is quite hard to follow.
comment:2 Changed 8 months ago by
Replying to sjamaan:
A potential solution might involve something akin to
canonicalize-expression
on the syntax form
Hm, after thinking about this some more, I believe this would require teaching the compiler about syntax-rules
and how to canonicalize its "templates".
Somehow that "feels" Very Wrong - we don't want to have to special case something like this. Users should be able to add their own expanders without requiring a special case for it.
Working example.