Optimizer sometimes incorrectly drops procedure arguments

[sjamaan]

Found by megane while looking into a patch of mine to improve variable replacements:

(define (foo bindings)                                                                            
  (define (append-map proc lst1)                                                                                                        
    (if lst1                                                                                                                            
        (proc 1)                                                                                                                        
        (proc 1 2)))                                                                                                                    
  (append-map (lambda (b a) (begin)) bindings))

Compile this with -O3 and it will error out with this message:

Error: Arguments to inlined call of `a150' do not match parameter-list (b a)

After fixing this, we can remove the (not captured) test in the 'replaceable code.

[megane]

Simpler still:

(define (foo x)
  (let ((bar (lambda (a b) (print a b))))
    (if x
        (bar 1)
        (bar 1 2))))

[felix winkelmann]

I don't see the problem here. Tha example code is clearly incorrect.

[megane]

This fails too, but shouldn't. The true branch is never called.

(define (foo x y)
  (define (append-map proc lst1 . lsts)
    (if (null? lsts)
        (proc 1)
        (proc 1 2)))
  (append-map (lambda (a b) (print a b)) x y))

[sjamaan]

This code seems valid to me but also triggers the error when compiled with -O2:

(define (foo x y)
  (define (append-map proc lst1 . lsts)
    (if (null? lsts)
        (proc 1)
        (proc 1 2)))
  (append-map (lambda (a b) (print a b)) x y)
  (append-map (lambda (a) (print a)) x))

[felix winkelmann]

Here is another test, submitted by megane. This triggers a compiler error, with the standard CHICKEN:

(define (foo x y)
  (define (append-map proc . lsts)
    (if (null? lsts)
        (proc 1)
        (apply proc lsts)))
  (append-map (lambda (a) (print a)))
  (append-map (lambda (a b) (print a b)) x y))

(foo 3 4)

[sjamaan]

Fixed by cf5d2aed000cfd292708d41b3774321bfec5eb67