Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#155 closed defect (fixed)

make chicken-doc work on windows

Reported by: felix winkelmann Owned by: felix winkelmann
Priority: major Milestone:
Component: extensions Version: 4.3.x
Keywords: chicken-doc Cc:
Estimated difficulty:

Description

The errors are too numerous, here a small selection:

  • file-locking is not supported on windows
  • file-name characters like '*', '?' and '!' have to be escaped
  • the index appears to be empty

create-directory has a bug in posixwin.scm, which should be fixed in 8b1b58249ce19147dab69440b731f6a97a37e158 (master).

Change History (10)

comment:1 Changed 14 years ago by Jim Ursetto

I can't accept this quite yet because I have never used Chicken on Windows and I do not even have a Windows development environment. I will work on that since I would like to get chicken-doc working on Windows. It will take some time.

Lack of file locking is a Chicken limitation, but I will work around it.

comment:2 in reply to:  1 Changed 14 years ago by felix winkelmann

Replying to zbigniew:

I can't accept this quite yet because I have never used Chicken on Windows and I do not even have a Windows development environment. I will work on that since I would like to get chicken-doc working on Windows. It will take some time.

I am going green with envy.

Lack of file locking is a Chicken limitation, but I will work around it.

I have committed two changes (r16955 and r16956), which make at least chicken-doc-admin -m ... work, but the index-file is ().

comment:3 Changed 14 years ago by Jim Ursetto

Status: newaccepted

comment:4 Changed 14 years ago by Jim Ursetto

Owner: changed from Jim Ursetto to felix winkelmann
Status: acceptedassigned

I committed some minor fixes to trunk of both chicken-doc and chicken-doc-admin. However it turns out the main culprit is that find-files is broken on Windows, because it was never synced with the UNIX version.

Additionally there were several changes required to even get Chicken to compile on MinGW (in both master and experimental). I will now use this ticket for that.

I would like to try something different and have you pull from my public git repository. I have already done the work of applying the required fixes to master and merging them back into experimental. Also I cherry-picked two critical commits from experimental into master. The changes are below. Assuming you agree with them, you don't have to do any work. ;)

git://3e8.org/chicken-core.git (master and experimental branches)

I find it nice to pull changes from an alien repository like mine into temporary branches so I could inspect the changes before merge--or add it as a remote. I'm sure you don't need me explaining how to use git though.

Any problems, or if this is ridiculous, let me know...

00dd069 Merge branch 'master' into experimental
0548541 Remove extra quotes in Makefile.mingw
0658aa8 Merge branch 'master' into experimental
de552df Fix find-files on Windows to include directories
4c8d3fb Use all: rule from defaults.make for MinGW
1c7765a removed more traces of chicken-setup
321e60a posixwin.c in bootstrap dir was using obsolete identifier
fc601b5 Remove remnants of for-each-line / for-each-argv-line

comment:5 Changed 14 years ago by felix winkelmann

Thanks. I have pulled your patches (works quite well) and will test chicken-doc on Monday.

comment:6 Changed 14 years ago by Jim Ursetto

OK great. Just to make sure I did not do something wrong: The merge graph shows my patches were duplicated on both sides of a merge into master, with different SHA1s (cherry-picked on one side?) I wanted to make sure I did not do anything wrong. The resulting code is perfectly fine of course.

comment:7 in reply to:  6 Changed 14 years ago by felix winkelmann

Replying to zbigniew:

OK great. Just to make sure I did not do something wrong: The merge graph shows my patches were duplicated on both sides of a merge into master, with different SHA1s (cherry-picked on one side?) I wanted to make sure I did not do anything wrong. The resulting code is perfectly fine of course.

I don't know. I haven't got a clue - I don't understand git. If it makes you feel better, just assume I have screwed it up.

comment:8 Changed 14 years ago by felix winkelmann

Resolution: fixed
Status: assignedclosed

Works like a charm. Well done, Jim!

comment:9 in reply to:  8 Changed 14 years ago by felix winkelmann

Replying to felix:

Works like a charm. Well done, Jim!

I forgot to add that I committed a small fix to chicken-doc: : must be escaped, it is not a valid filename character.

comment:10 Changed 14 years ago by (none)

Milestone 4.4.0 deleted

Note: See TracTickets for help on using tickets.