Opened 6 years ago

Closed 3 months ago

#1520 closed defect (fixed)

binary-search: test failure: (=) bad argument type - not a number: #f

Reported by: Mario Domenech Goulart Owned by:
Priority: major Milestone: 5.4
Component: extensions Version: 5.0.0
Keywords: binary-search Cc:
Estimated difficulty:

Description

See ​http://salmonella-linux-x86.call-cc.org/master-debugbuild/gcc/linux/x86/2018/08/21/salmonella-report/test/binary-search.html

Change History (6)

comment:2 Changed 6 months ago by felix winkelmann

Milestone: someday → 5.4

comment:4 Changed 4 months ago by sjamaan

Resolution: fixed
Status: closed → reopened

My bad, it's x86-specific: ​http://salmonella-linux-x86.call-cc.org/master/clang/linux/x86/2023/12/20/salmonella-report/test/binary-search.html

comment:5 Changed 4 months ago by sjamaan

I think the problem is that (square x) returns bignums on 32-bit platforms, while binary-search assumes fixnums everywhere.

The code checks that the sequence is within fixnum range, but it doesn't do so for the return value of proc in the loop (but still calls fixnum ops on it!)

comment:6 Changed 3 months ago by Mario Domenech Goulart

Resolution: → fixed
Status: reopened → closed

The issue been fixed with the 0.2 release (​http://bugs.call-cc.org/changeset/43071/project). After that, tests succeed: ​http://salmonella-linux-x86.call-cc.org/master/clang/linux/x86/2023/12/27/salmonella-report/test/binary-search.html

Note: See TracTickets for help on using tickets.