Opened 7 years ago

Closed 6 years ago

#1361 closed enhancement (fixed)

Update explicit info strings in calls to `getter-with-setter`

Reported by: felix winkelmann Owned by:
Priority: minor Milestone: 5.0
Component: core libraries Version: 5.0.0
Keywords: Cc:
Estimated difficulty: trivial

Description

getter-with-setter allows passing an optional info string that is shown when printing a procedure. Currently these strings do not contain the module prefix, which is added for internally generated info strings.

For consistency, we should add the module-prefixes manually in uses of getter-with-setter.

Change History (2)

comment:1 Changed 7 years ago by kristianlm

I think it's possible that if we fix #1363, we can get away in some cases by removing the info-string altogether. Take this, for example:

;; library.scm:3045
(set! caar (getter-with-setter caar (lambda (x y) (set-car! (car x) y)) "(caar p)"))

From what I gather, the only reason we can't just re-use the info-string from the original caar getter is issue #1363.

comment:2 Changed 6 years ago by sjamaan

Resolution: fixed
Status: newclosed

This should be alright now.

Note: See TracTickets for help on using tickets.