Opened 13 years ago

Closed 13 years ago

#119 closed defect (fixed)

`define-method` does not handle dotted argument lists

Reported by: felix winkelmann Owned by: Tony Sidaway
Priority: minor Milestone:
Component: extensions Version: 4.2.x
Keywords: tinyclos Cc:
Estimated difficulty:

Description

(define-method (foo ... . more) ...) will throw an error. #!rest works fine, though.

Change History (4)

comment:1 Changed 13 years ago by Tony Sidaway

I'd like to look at this, with your permission, Felix. The innards of tinyclos are fresh in my mind and I can easily make define-method parse dotted argument lists. There may be ramifications in the compute-methods sequence but I'll watch out for them and fix them.

comment:2 in reply to:  1 Changed 13 years ago by felix winkelmann

Replying to tonysidaway:

I'd like to look at this, with your permission, Felix. The innards of tinyclos are fresh in my mind and I can easily make define-method parse dotted argument lists. There may be ramifications in the compute-methods sequence but I'll watch out for them and fix them.

Yes, sure. Please go ahead.

comment:3 Changed 13 years ago by Tony Sidaway

Owner: set to Tony Sidaway
Status: newassigned

I've committed a fix and bumped the version to 1.6.2 (the egg is still marked hidden in the meta file).

There are some basic tests for methods with dotted arguments in tests/run.scm.

Please check this and close the ticket if it's satisfactory.

comment:4 Changed 13 years ago by felix winkelmann

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.