Opened 12 years ago
Closed 11 years ago
#978 closed defect (fixed)
Ports don't keep track of "column" anymore - restore this
| Reported by: | sjamaan | Owned by: | sjamaan |
|---|---|---|---|
| Priority: | not urgent at all | Milestone: | someday |
| Component: | core libraries | Version: | 4.8.x |
| Keywords: | ports, position | Cc: | |
| Estimated difficulty: |
Description
Slot 5 is no longer being updated by any port procedure except read-char. This causes port-position to return useless values.
This should be restored for read-line and friends.
Attachments (1)
Change History (3)
comment:1 Changed 12 years ago by
| Milestone: | 4.9.0 → someday |
|---|---|
| Priority: | minor → not urgent at all |
Changed 12 years ago by
| Attachment: | 0002-Also-add-column-row-counting-to-read-string.patch added |
|---|
comment:2 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I think the fix for this ticket is acceptable. There's no reason to keep it open; the attached fix for read-string can hopefully be found when we need it, or else we can always write it again from scratch.
Note: See
TracTickets for help on using
tickets.
read-line is fixed in a302a6dcc9 per Peter's patch. I also added some tests for the affected ports.
I think we can leave read-string alone -- if you care about lines, you're probably using read-char or read-line anyway. I'm attaching Peter's read-string patch to the ticket for posterity, but I recommend we leave it alone until someone complains.