Opened 11 years ago
Closed 11 years ago
#965 closed defect (fixed)
'test -e' is not supported on Solaris sh
| Reported by: | mikele | Owned by: | mikele |
|---|---|---|---|
| Priority: | minor | Milestone: | 4.9.0 |
| Component: | build system | Version: | 4.8.x |
| Keywords: | Cc: | ||
| Estimated difficulty: |
Description
While building chicken on Solaris10, the script identify.sh failed because of 'test -e'. Suggested fix: use 'test -f'. Same job, more portable.
Change History (3)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
| Owner: | set to mikele |
|---|---|
| Status: | new → assigned |
Fixed in 689d41ed86, please close after verifying.
comment:3 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Fix seems good, but I wonder why identity.sh is being invoked when building from a tarball -- the component files (buildbranch, etc.) should already exist. Is this expected?
I also wonder if all the variables (host, branchname0, etc.) should be moved inside the test for ".git", as they aren't used outside that test. If .git does not exist, the only effect that identity.sh can have is just "touch buildbranch".