Ticket #838 (closed defect: fixed)

Opened 12 months ago

Last modified 12 months ago

matrix-utils: cons called with one argument

Reported by: sjamaan Owned by: iraikov
Priority: minor Milestone:
Component: extensions Version: 4.7.x
Keywords: Cc:

Description

The matrix-utils egg has two places where it's calling the Scheme cons procedure with only one argument. From the looks of it, there's a y that accidentally got erased (there are two spaces between cons and b):

Index: matrix-utils.scm
===================================================================
--- matrix-utils.scm	(revision 26685)
+++ matrix-utils.scm	(working copy)
@@ -293,7 +293,7 @@
 					(f (vector-ref A (fx+ (cdr x+b) y)) ax) ax)))))))
 	   
 	   ((= order ColMajor)
-	    (fold-ec x0 (:parallel (:range b (fx* N ix) (fx* N M) M) (:range y iy ey)) (cons  b)
+	    (fold-ec x0 (:parallel (:range b (fx* N ix) (fx* N M) M) (:range y iy ey)) (cons y b)
 		     (lambda (y+b ax)
 		       (fold-ec ax (:range x ix ex) x
 				(lambda (x ax)
@@ -344,7 +344,7 @@
 				    (f i j (vector-ref A (fx+ (cdr x+b) y)) ax) ax))))))
 	   
 	   ((= order ColMajor)
-	    (fold-ec x0 (:parallel (:range b (fx* N ix) (fx* N M) M) (:range y iy ey)) (cons  b)
+	    (fold-ec x0 (:parallel (:range b (fx* N ix) (fx* N M) M) (:range y iy ey)) (cons y b)
 		     (lambda (y+b ax)
 		       (fold-ec ax (:range x ix ex) x
 				(lambda (x ax)

The above patch has NOT been tested. I don't have the BLAS library installed, so matrix-utils cannot be installed either as it depends on the blas egg.

This was found by Mario's scrutiny run, see http://parenteses.org/mario/misc/specialize-report/install/matrix-utils.html

Change History

Changed 12 months ago by felix

  • milestone 4.8.0 deleted

Changed 12 months ago by iraikov

  • status changed from new to closed
  • resolution set to fixed

Fixed in release 1.13 of matrix-utils, thanks for reporting.

Note: See TracTickets for help on using tickets.