Opened 8 years ago

Closed 6 years ago

#832 closed defect (fixed)

tokyocabinet: Error in tc-bdb-fwm-keys procedure

Reported by: sjamaan Owned by: Alex Shinn
Priority: minor Milestone:
Component: extensions Version: 4.7.x
Keywords: Cc:
Estimated difficulty:

Description

There seems to be a problem in the order and types of arguments passed to the C function "tcbdbfwmkeys", as indicated by the scrutinizer at http://parenteses.org/mario/misc/specialize-report/install/tokyocabinet.html

I don't have the Tokyocabinet library installed, so the patch below was not tested.

Index: tokyocabinet.scm
===================================================================
--- tokyocabinet.scm	(revision 26685)
+++ tokyocabinet.scm	(working copy)
@@ -431,7 +431,7 @@
 ;; negative max for no limit
 (define (tc-bdb-fwm-keys bdb prefix max)
   (let ((tc-list
-         (make-tc-list (%tc-bdb-fwmkeys (string-length prefix) bdb prefix max))))
+         (make-tc-list (%tc-bdb-fwmkeys bdb prefix (string-length prefix) max))))
     (and (tc-list-ptr tc-list)
          tc-list)))

Change History (2)

comment:1 Changed 8 years ago by felix winkelmann

Milestone: 4.8.0

comment:2 Changed 6 years ago by sjamaan

Resolution: fixed
Status: newclosed

Fixed in r27079

Note: See TracTickets for help on using tickets.