Opened 9 years ago

Closed 8 years ago

#792 closed change request (fixed)

CR: deprecate "make" syntax from "setup-api" module

Reported by: felix winkelmann Owned by:
Priority: minor Milestone:
Component: core libraries Version: 4.7.x
Keywords: make setup-api Cc:
Estimated difficulty:

Description

The functionality of this syntax is already available with the make egg and is not used inside the core system. Therefore it should be deprecated. A patch to do so is attached.

Attachments (1)

0001-deprecate-make-syntax.patch (1.7 KB) - added by felix winkelmann 9 years ago.

Download all attachments as: .zip

Change History (10)

Changed 9 years ago by felix winkelmann

comment:1 Changed 9 years ago by Moritz Heidkamp

Shouldn't there be a poll? How do I add one? :-)

comment:2 Changed 9 years ago by Christian Kellermann

With my small shell-fu the following eggs would be affected:

find ./release/4 -name \*.setup  -exec grep -H make\  {} \; |grep trunk | cut -f1 -d: |sort -u | while read f; do basename $f; done
9ML-toolkit.setup
bind.setup
crunch.setup
dbus.setup
dissector.setup
easyffi.setup
flsim.setup
hyde.setup
iexpr.setup
jbogenturfahi.setup
kanren.setup
loop.setup
make.setup
miniML.setup
nemo.setup
objc.setup
openal.setup
opengl.setup
pulseaudio.setup
qt.setup
qwiki.setup
scss.setup
signal-diagram.setup
spiffy-uri-match.setup
spock.setup
stalin.setup
static-modules.setup
sxml-informal.setup
utf8.setup
vandusen.setup
zmq.setup

That's 31 a managable small number. So for the sake of a leaner core system I am for it.

comment:3 in reply to:  1 Changed 9 years ago by Mario Domenech Goulart

Replying to syn:

Shouldn't there be a poll? How do I add one? :-)

The syntax is something like [[Poll(OMG R U OK bro?; Yes; No)]]

comment:4 Changed 9 years ago by Mario Domenech Goulart

Since only a few eggs depend on make and adapting them to use an egg is trivial, I'm for deprecating (then removing) core's make.

comment:5 Changed 9 years ago by sjamaan

"make" it so!

comment:6 Changed 9 years ago by felix winkelmann

comment:7 Changed 9 years ago by felix winkelmann

Ok - the patch will be posted on chicken-hackers.

comment:8 in reply to:  7 Changed 9 years ago by Christian Kellermann

Replying to felix:

Ok - the patch will be posted on chicken-hackers.

I must have missed it somehow...

comment:9 Changed 8 years ago by sjamaan

Resolution: fixed
Status: newclosed

It was posted here. This ticket can be closed.

Note: See TracTickets for help on using tickets.