Opened 13 years ago
Closed 12 years ago
#592 closed defect (fixed)
doctype egg is missing sxml conversion rule for generic HTML doctype
| Reported by: | Moritz Heidkamp | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | unknown | Version: | 4.7.x |
| Keywords: | Cc: | ||
| Estimated difficulty: |
Description
The doctype egg exports a set of sxml conversion rules (doctype-rules). These are missing a conversion rule for the generic HTML doctype that's exported as doctype-html.
Attachments (2)
Change History (8)
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
| Milestone: | 4.8.0 |
|---|
comment:3 Changed 12 years ago by
May I suggest that the rules follow the lead of the module exports themselves, and add doctype-* names for all the existing rules and for doctype-html?
I will gladly provide a patch to that effect if you the "meh"s about it, zbigniew :-)
comment:4 Changed 12 years ago by
Sure, I would accept that patch.
FYI, I normally just use (lit "<!doctype html>") these days rather than bringing in a extra dependency. But if you want to use the doctype egg, it's a good solution.
Changed 12 years ago by
| Attachment: | doctype-prefix-on-sxml-rules-and-generic-html-rule.diff added |
|---|
Changed 12 years ago by
| Attachment: | update-doctype-sxml-rules-example.diff added |
|---|
comment:5 Changed 12 years ago by
I was momentarily confused by this recently as well; attached patch implements the change Alaric suggests above.
comment:6 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I did not apply your patch as-is because I wanted doctype- prefix rules added in tandem with the old rules, for proper back compat. However you gave me the impetus to finally implement this. Fixed in doctype 2.1, along with an old bug in the html-2.0 rule.
The rules were added by sjamaan prior to the introduction of
doctype-html, and prior to the deprecation of the non-prefixed doctypes. What do you propose the new rule be called? Plainhtmlwill conflict with the "html" tag. In my opinion the rules should be prefixed with doctype- with the old aliases retained but deprecated. However I am not currently using these rules (or this egg, in point of fact), so it's up to you.