Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#361 closed defect (fixed)

sendfile broken for chickens >= 4.6.0

Reported by: felix winkelmann Owned by: certainty
Priority: critical Milestone:
Component: extensions Version: 4.6.x
Keywords: sendfile Cc: sjamaan
Estimated difficulty:

Description

Sendfile invokes (##sys#fudge 16), which isn't available anymore, and calls ##sys#thread-block-for-timeout! with invalid fixnum timeout values.

Attachments (1)

sendfile.diff (2.0 KB) - added by felix winkelmann 10 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by sjamaan

Owner: set to certainty
Status: newassigned

I'll let David deal with this. By the way, what did (##sys#fudge 16) do?

comment:2 in reply to:  1 Changed 10 years ago by felix winkelmann

Replying to sjamaan:

I'll let David deal with this. By the way, what did (##sys#fudge 16) do?

(##sys#fudge 16) returns the current milliseconds since startup (now as flonum).

Attached is a patch, but I'm still fighting with a modified version of the scheduler, so I have done only very limited testing.

Changed 10 years ago by felix winkelmann

Attachment: sendfile.diff added

comment:3 Changed 10 years ago by certainty

Resolution: fixed
Status: assignedclosed

Thanks very much for the patch.
I've applied it and released a new version.
I probably should have looked for a away to avoid procedures out of the ##sys#-namespace where possible, before. :)

comment:4 in reply to:  3 Changed 10 years ago by felix winkelmann

Replying to certainty:

Thanks very much for the patch.
I've applied it and released a new version.
I probably should have looked for a away to avoid procedures out of the ##sys#-namespace where possible, before. :)

Have you tested it? I am not 100% sure this change works with pre 4.6.0 chickens!

Note: See TracTickets for help on using tickets.