Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#151 closed defect (wontfix)

henrietta does not obey (files...) from meta

Reported by: ddp Owned by:
Priority: minor Milestone:
Component: extensions Version: 4.3.0
Keywords: Cc:
Estimated difficulty:

Description

Along with the yelp egg source, I checked in three PDFs, just for reference. They are not listed in the egg's meta and yet henrietta is handing them down on egg install:

((egg "yelp.egg")

(synopsis "An interface to the Yelp developer API")
(category web)
(author "derrell piper?")
(license "BSD")
(doc-from-wiki)
(needs json)
(test-depends test)
(files

"yelp.scm"
"yelp.setup"
"tests"))
.
.
.

reading files ...

./api-phone.pdf
./yelp.scm
./api-review-search.pdf
./api-neighborhood.pdf
./yelp.meta
./yelp.setup

I was expecting that henrietta would only download what's listed in the (files...) clause.

Change History (4)

comment:1 Changed 12 years ago by felix winkelmann

Henrietta checks out the files directly from svn, the files property is currently ignored.

comment:2 Changed 12 years ago by (none)

Milestone 4.4.0 deleted

comment:3 Changed 11 years ago by felix winkelmann

Milestone: 4.6.0
Resolution: wontfix
Status: newclosed

I thought some sore about this and I have no good solution in the moment. Since henrietta has to run fast, the operations performed should be absolutely minimal: it already has to access the svn repo twice for each request (in the default case of accessing via subversion) and incorrect or missing files listed in the .meta file would create yet another error-situation to handle (currently there is only "egg missing").

To keep things simple I recommend the following: put additional files and extra documentation into a separate directory, say:

:
release/
  :
  4/
    :
    yelp/
      trunk/
      tags/
      doc/      <-- docs
    :

Since only the trunk and tags directories are processed by tools that access the repository (like henrietta), you are free to add as many extra directories you like.

This is not a perfect solution - in the event of reorganizing the repository layout (see ticket #91) we will be able to put additional material into the dev (development) part of the repository, which could hopefully make things somewhat cleaner.

comment:4 Changed 11 years ago by felix winkelmann

Milestone: 4.6.0

Milestone 4.6.0 deleted

Note: See TracTickets for help on using tickets.