Opened 6 months ago

Last modified 6 months ago

#1436 new change request

Don't disable inline file generation with -O5 (disable-interrupts)

Reported by: megane Owned by:
Priority: minor Milestone: someday
Component: compiler Version: 5.0
Keywords: inlining Cc:
Estimated difficulty:

Description

(I'm assuming here that disable-interrupts is enough to implement critical sections in concurrency related code.)

The disable-interrupts declaration correctly disables the global inline file generation. My belief is that inlining is more of an optimization than disabling the interrupt checks.

So removing the disable-interrupts from O5 would be one choice.

But wouldn't it be OK to always disable the checks in inlined code? The functions made available for global inlining are controlled explicitly by the user by the use of the inline declaration. So if you need interrupt checks (a function doing some heavy computation perhaps) just don't make it available for global inlining.

Change History (1)

comment:1 Changed 6 months ago by megane

  • Type changed from defect to change request
Note: See TracTickets for help on using tickets.