Opened 6 years ago

Closed 3 years ago

#1307 closed defect (fixed)

invalid number of parameters in install target on Windows

Reported by: zmyrgel Owned by:
Priority: minor Milestone: someday
Component: build system Version: 4.11.0
Keywords: Cc:
Estimated difficulty: medium

Description

I tried to install chicken on windows following the instructions from https://wiki.call-cc.org/compiling-chicken-on-windows-xp-with-mingw but the install part failed with following:

1 File(s) copied
xcopy /Y .\feathers.1 "C:\chicken\share\man\man1"
.\feathers.1
1 File(s) copied
mkdir  "C:\chicken\share\chicken\doc\manual"
xcopy /Y .\manual-html\* "C:\chicken\share\chicken\doc\manual"
0 File(s) copied
xcopy /Y .\README "C:\chicken\share\chicken\doc"
.\README
1 File(s) copied
xcopy /Y .\LICENSE "C:\chicken\share\chicken\doc"
.\LICENSE
1 File(s) copied
xcopy /Y .\setup.defaults "C:\chicken\share\chicken"
.\setup.defaults
1 File(s) copied
xcopy /Y .\feathers.tcl "C:\chicken/share/chicken"
Invalid number of parameters
.\rules.make:415: recipe for target 'install-other-files' failed
mingw32-make: *** [install-other-files] Error 4

C:\Users\tmy\Downloads\chicken-4.11.0>

Seems DATADIR variable is using wrong separators so the xcopy mistakes path as command argument.
Replacing the path arguments separaters with backslashes made the install target complete succesfully.

Change History (3)

comment:1 Changed 5 years ago by zmyrgel

I tested the above with PREFIX using backslashes, heres the result with forward slashes:

C:chicken-profile.exe
1 File(s) copied
xcopy /Y csc.exe "c:\chicken\bin"
C:csc.exe
1 File(s) copied
xcopy /Y chicken-bug.exe "c:\chicken\bin"
C:chicken-bug.exe
1 File(s) copied
xcopy /Y chicken-status.exe "c:\chicken\bin"
C:chicken-status.exe
1 File(s) copied
xcopy /Y chicken-install.exe "c:\chicken\bin"
C:chicken-install.exe
1 File(s) copied
xcopy /Y chicken-uninstall.exe "c:\chicken\bin"
C:chicken-uninstall.exe
1 File(s) copied
xcopy /Y feathers.bat \
  "c:/chicken/bin"
Invalid number of parameters
.\rules.make:363: recipe for target 'install-bin' failed
mingw32-make: *** [install-bin] Error 4

C:\Users\tmy\Downloads\chicken-4.11.0>

comment:2 Changed 5 years ago by sjamaan

Estimated difficulty: medium

comment:3 Changed 3 years ago by sjamaan

Resolution: fixed
Status: newclosed

We've also done a lot of work on improving shell quoting and done several tests with weird path names. And indeed, forward slashes are required. Many people have tested on Windows, so I think the bug probably is gone already. (note that this was filed against CHICKEN 4.11)

If it's still failing, please reopen.

Note: See TracTickets for help on using tickets.