Opened 7 years ago

Closed 7 years ago

#1072 closed defect (fixed)

[spiffy] [PATCH] Improve HTML in the simple-directory-handler

Reported by: RvdH Owned by: sjamaan
Priority: major Milestone: someday
Component: unknown Version: 4.8.x
Keywords: html directory-handler simple-directory-handler Cc:
Estimated difficulty:

Description

I know the simple-directory-handler is made to be simple. Still, this patch improves the HTML of the simple-directory-handler in the following ways:

  1. Adds the obligatory "xmlns" and "xml:lang" attributes to the html element.
  2. Changes the h2 element into an h1 element. Using a h2 element here is syntactically correct, but semantically it is not. The first header element in a document should be the h1 element. If the header is considered too large, change the styling, not the element itself.
  3. Adds table headers to the columns.

Attachments (1)

valid-html-simple-directory-handler-rvdh.patch (894 bytes) - added by RvdH 7 years ago.

Download all attachments as: .zip

Change History (2)

comment:1 Changed 7 years ago by sjamaan

Resolution: fixed
Status: newclosed

Thanks, this is definitely an improvement which fits within the scope of simple-directory-handler. I've applied the patch.

Note: See TracTickets for help on using tickets.