Summary
irregex chunked matching breaks when using positive lookbehind with submatches
Metadata
- Id: e9cd5cda7eb349e208b10c9797e6766bfa6df9c4
- Trac id: 1066
- Type: defect
- Reporter: sjamaan
- Owner:
- Cc:
- Status: closed
- Component: unknown
- Estimated difficulty:
- Resolution: fixed
- Priority: minor
- Milestone: 4.9.0
- Version: 4.8.x
- Changetime: 2013-11-18 22:13:33 UTC
- Created: 2013-11-16 13:41:45 UTC
- Keywords: irregex
Description
When using a custom, non-trivial chunker (ie, not the shipped string chunker), submatches in (positive) lookbehind patterns will be returned as string-chunker type chunks. This breaks the expectation of returning a chunk in our own custom type like we get with any other submatch.
This has been reported to Alex, and is included in the upstream test suite as a breaking test. Too complicated to make a simple test script for CHICKEN, but when fixed should be backported.
For now I hope we can get this into 4.9.0, but it may need to be postponed.
Changes and comments
[2013-11-16 13:43:11 UTC] sjamaan changed priority from major to minor
[2013-11-16 13:43:11 UTC] sjamaan wrote:
Making it minor, as not many people will be using the chunking API (and of those few people, using positive lookbehind with submatches).
[2013-11-18 22:13:33 UTC] sjamaan changed status from new to closed
[2013-11-18 22:13:33 UTC] sjamaan set resolution to fixed
[2013-11-18 22:13:33 UTC] sjamaan wrote:
Fixed by 6ca60446ca6044