Summary

[spiffy] [PATCH] Improve HTML in the simple-directory-handler

Metadata

• Id: e17c2688a97b7fae4f5df636735351444ed28e22
• Trac id: 1072
• Type: defect
• Reporter: RvdH
• Owner: sjamaan
• Cc:
• Status: closed
• Component: unknown
• Estimated difficulty:
• Resolution: fixed
• Priority: major
• Milestone: someday
• Version: 4.8.x
• Changetime: 2013-11-22 16:43:24 UTC
• Created: 2013-11-22 13:31:02 UTC
• Keywords: html directory-handler simple-directory-handler

Attachments

• e17c2688a97b7fae4f5df636735351444ed28e22/attachments/valid-html-simple-directory-handler-rvdh.patch

Description

I know the simple-directory-handler is made to be simple. Still, this patch improves the HTML of the simple-directory-handler in the following ways:

1. Adds the obligatory "xmlns" and "xml:lang" attributes to the html element.
2. Changes the h2 element into an h1 element. Using a h2 element here is syntactically correct, but semantically it is not. The first header element in a document should be the h1 element. If the header is considered too large, change the styling, not the element itself.
3. Adds table headers to the columns.

Changes and comments

[2013-11-22 13:31:19 UTC] RvdH attached valid-html-simple-directory-handler-rvdh.patch (description=#f)

[2013-11-22 16:43:24 UTC] sjamaan changed status from new to closed

[2013-11-22 16:43:24 UTC] sjamaan set resolution to fixed

[2013-11-22 16:43:24 UTC] sjamaan wrote:

Thanks, this is definitely an improvement which fits within the scope of simple-directory-handler. I've applied the patch.