Summary

tokyocabinet: Error in tc-bdb-fwm-keys procedure

Metadata

• Id: d9955909163b8f133cf80b99ed349e33a0bf6952
• Trac id: 832
• Type: defect
• Reporter: sjamaan
• Owner: ashinn
• Cc:
• Status: closed
• Component: extensions
• Estimated difficulty:
• Resolution: fixed
• Priority: minor
• Milestone:
• Version: 4.7.x
• Changetime: 2014-06-08 16:44:23 UTC
• Created: 2012-05-13 13:18:22 UTC
• Keywords:

Description

There seems to be a problem in the order and types of arguments passed to the C function "tcbdbfwmkeys", as indicated by the scrutinizer at http://parenteses.org/mario/misc/specialize-report/install/tokyocabinet.html

I don't have the Tokyocabinet library installed, so the patch below was not tested.

 Index: tokyocabinet.scm
 ===================================================================
 --- tokyocabinet.scm	(revision 26685)
 +++ tokyocabinet.scm	(working copy)
 @@ -431,7 +431,7 @@
  ;; negative max for no limit
  (define (tc-bdb-fwm-keys bdb prefix max)
    (let ((tc-list
 -         (make-tc-list (%tc-bdb-fwmkeys (string-length prefix) bdb prefix max))))
 +         (make-tc-list (%tc-bdb-fwmkeys bdb prefix (string-length prefix) max))))
      (and (tc-list-ptr tc-list)
           tc-list)))

Changes and comments

[2012-05-18 12:47:16 UTC] felix removed milestone 4.8.0

[2014-06-08 16:44:23 UTC] sjamaan changed status from new to closed

[2014-06-08 16:44:23 UTC] sjamaan set resolution to fixed

[2014-06-08 16:44:23 UTC] sjamaan wrote:

Fixed in r27079