Summary
Drop regex dependencies from chicken-core scripts
Metadata
- Id: d864f99f30ae34eca46e7fe38158bd457516dfe2
- Trac id: 725
- Type: defect
- Reporter: mario
- Owner: felix
- Cc:
- Status: closed
- Component: core tools
- Estimated difficulty:
- Resolution: fixed
- Priority: not urgent at all
- Milestone:
- Version: 4.7.x
- Changetime: 2011-12-01 10:05:44 UTC
- Created: 2011-11-16 13:07:53 UTC
- Keywords: regex, core scripts
Attachments
- d864f99f30ae34eca46e7fe38158bd457516dfe2/attachments/0001-Remove-unneeded-dependencies-on-regex-in-scripts-725.patch
Description
Make the following scripts use irregex instead of regex:
- dpkg-eggs.scm
- make-eggdoc.scm
- wiki2html.scm
- tools.scm
(are they even used?)
Changes and comments
[2011-11-16 14:24:02 UTC] felix changed status from new to assigned
[2011-11-16 14:24:02 UTC] felix set owner to felix
[2011-11-16 14:24:17 UTC] felix removed milestone 4.8.0
[2011-11-16 17:30:19 UTC] zbigniew wrote:
This change appears to be unnecessary.
- dpkg-eggs.scm -- Claims dependency on regex, but actually has none; (use regex) can be removed.
- make-eggdoc.scm -- Claims dependency on regex, but actually has none; (use regex) can be removed.
- tools.scm -- Was already converted to irregex in 8a516a0425.
- wiki2html.scm -- Also depends on htmlprag and matchable, so converting to irregex gains you nothing except verbosity.
Overall, it seems that (use regex) was added to tools.scm just to provide string-match, but string-match is only used in wiki2html.scm, which already depends on regex.
[2011-11-16 18:15:49 UTC] mario wrote:
You are right, Jim. Boy, what a mess I've made!
I have no idea why I thought/saw string-match in tools.scm. I'm really sorry for all the confusion.
[2011-11-16 18:50:43 UTC] zbigniew attached 0001-Remove-unneeded-dependencies-on-regex-in-scripts-725.patch (description=#f)
[2011-11-16 18:52:30 UTC] zbigniew wrote:
Attached will fix by removing unused regex deps. Should I push it myself?
Note that dpkg-eggs.scm is still broken afterward because it uses ##sys#pathname-directory-separator, which no longer exists. It could be changed to make-pathname but it's probably safer for Ivan to fix that (if it is still in use).