Summary

irc: tcp-read-timeout not paramaterized everywhere that it needs to be

Metadata

• Id: c2fc77ae396092c1b01f9ae609ad780083cbfc77
• Trac id: 1150
• Type: defect
• Reporter: acharlton
• Owner: felix
• Cc:
• Status: closed
• Component: extensions
• Estimated difficulty:
• Resolution: fixed
• Priority: minor
• Milestone: someday
• Version: 4.9.x
• Changetime: 2014-08-17 21:13:55 UTC
• Created: 2014-08-16 22:58:32 UTC
• Keywords: irc

Attachments

• c2fc77ae396092c1b01f9ae609ad780083cbfc77/attachments/irc.patch

Description

The parameter tcp-read-timeout is correctly set to irc:connection-reconnect-timeout in irc:connect, but it isn’t elsewhere. Notably, the procedure read-input, which calls read-line, should have a parametrization of tcp-read-timeout. Otherwise, the read-line times-out after the tcp default of one minute which is quite a bit shorter than desirable (the default irc:connection-reconnect-timout is one hour).

read-input should be the only (additional) location where tcp-read-timout must be set. Higher level procedures (irc:listen, irc:run-message-loop) all read the input port through this procedure. The attached patch does this.

Changes and comments

[2014-08-16 22:58:54 UTC] acharlton attached irc.patch (description=#f)

[2014-08-17 21:13:55 UTC] felix changed status from new to closed

[2014-08-17 21:13:55 UTC] felix set resolution to fixed

[2014-08-17 21:13:55 UTC] felix wrote:

Should be fixed in 1.9.8.