Summary
matrix-utils: cons called with one argument
Metadata
- Id: ab527db74048adffed56cad04d978780c336ab5d
- Trac id: 838
- Type: defect
- Reporter: sjamaan
- Owner: iraikov
- Cc:
- Status: closed
- Component: extensions
- Estimated difficulty:
- Resolution: fixed
- Priority: minor
- Milestone:
- Version: 4.7.x
- Changetime: 2012-06-01 09:25:59 UTC
- Created: 2012-05-13 16:41:18 UTC
- Keywords:
Description
The matrix-utils egg has two places where it's calling the Scheme cons procedure with only one argument. From the looks of it, there's a y that accidentally got erased (there are two spaces between cons and b):
Index: matrix-utils.scm =================================================================== --- matrix-utils.scm (revision 26685) +++ matrix-utils.scm (working copy) @@ -293,7 +293,7 @@ (f (vector-ref A (fx+ (cdr x+b) y)) ax) ax))))))) ((= order ColMajor) - (fold-ec x0 (:parallel (:range b (fx* N ix) (fx* N M) M) (:range y iy ey)) (cons b) + (fold-ec x0 (:parallel (:range b (fx* N ix) (fx* N M) M) (:range y iy ey)) (cons y b) (lambda (y+b ax) (fold-ec ax (:range x ix ex) x (lambda (x ax) @@ -344,7 +344,7 @@ (f i j (vector-ref A (fx+ (cdr x+b) y)) ax) ax)))))) ((= order ColMajor) - (fold-ec x0 (:parallel (:range b (fx* N ix) (fx* N M) M) (:range y iy ey)) (cons b) + (fold-ec x0 (:parallel (:range b (fx* N ix) (fx* N M) M) (:range y iy ey)) (cons y b) (lambda (y+b ax) (fold-ec ax (:range x ix ex) x (lambda (x ax)
The above patch has NOT been tested. I don't have the BLAS library installed, so matrix-utils cannot be installed either as it depends on the blas egg.
This was found by Mario's scrutiny run, see http://parenteses.org/mario/misc/specialize-report/install/matrix-utils.html
Changes and comments
[2012-05-18 12:47:29 UTC] felix removed milestone 4.8.0
[2012-06-01 09:25:59 UTC] iraikov changed status from new to closed
[2012-06-01 09:25:59 UTC] iraikov set resolution to fixed
[2012-06-01 09:25:59 UTC] iraikov wrote:
Fixed in release 1.13 of matrix-utils, thanks for reporting.