Summary

http-session's session-del! fails when the entry is the session-item's first binding

Metadata

• Id: 8e0b101f20338e2f65d2885ffc8ba042193f72a7
• Trac id: 994
• Type: defect
• Reporter: evhan
• Owner: mario
• Cc:
• Status: closed
• Component: extensions
• Estimated difficulty:
• Resolution: fixed
• Priority: minor
• Milestone: someday
• Version: 4.8.x
• Changetime: 2013-03-05 23:51:42 UTC
• Created: 2013-03-05 10:48:39 UTC
• Keywords: http-session

Attachments

• 8e0b101f20338e2f65d2885ffc8ba042193f72a7/attachments/fix-session-del-on-first-item.patch

Description

session-del! currently fails to remove an entry for the given key when that entry is the first item in the pertinent session-item's bindings alist (because alist-delete! just returns the alist's cdr when its car is to be removed (without set-cdr!ing anything) and the session-item's bindings slot is never updated to refer to the new start of the alist). The attached patch fixes this.

Changes and comments

[2013-03-05 10:49:19 UTC] evhan attached fix-session-del-on-first-item.patch (description=#f)

[2013-03-05 23:51:42 UTC] mario changed status from new to closed

[2013-03-05 23:51:42 UTC] mario set resolution to fixed

[2013-03-05 23:51:42 UTC] mario wrote:

Thanks a lot, Evan. I've pushed your patch and released version 2.8. I've moved the http-session repository to github: https://github.com/mario-goulart/http-session