Summary
yelp's test script is broken
Metadata
- Id: 8b6b08e76a058f74f6d94646ddced58b4fb06775
- Trac id: 603
- Type: defect
- Reporter: mario
- Owner: ddp
- Cc:
- Status: closed
- Component: extensions
- Estimated difficulty:
- Resolution: wontfix
- Priority: major
- Milestone:
- Version: 4.7.x
- Changetime: 2014-02-02 21:35:26 UTC
- Created: 2011-06-14 21:00:56 UTC
- Keywords: yelp
Description
See http://tests.call-cc.org/master/linux/x86/2011/06/14/salmonella-report/tests/yelp.html
Changes and comments
[2011-08-10 21:56:17 UTC] ddp changed status from new to assigned
[2011-08-10 21:56:17 UTC] ddp wrote:
Yes and no. The issue is that the Yelp API requires a developer key. For the obvious reason, I don't want to check mine in, so I wrote the test script such that if you go and get one and put it in a magically named file in the right place all will work. Not particularly useful for regression testing I realize, but better than not checking in the test script at all, methinks. Maybe I should go see if I can get another API key out of Yelp.
[2011-11-03 14:28:25 UTC] felix removed milestone 4.8.0
[2012-10-09 20:02:07 UTC] ddp wrote:
I asked Yelp for an additional API key. If they give me one (and assuming it's a v1 API YWSID), I'll check it into the test script. Otherwise I'm going to close this ticket because nothing's really broken. A while back I added additional comments about what's going on in the test script and in the Wiki entry for the egg. Everyone using this egg needs their own private YWSID key from Yelp. See http://www.yelp.com/developers for more information.
[2013-08-26 22:56:34 UTC] ddp changed status from assigned to closed
[2013-08-26 22:56:34 UTC] ddp set resolution to wontfix
[2013-08-26 22:57:01 UTC] ddp wrote:
I never heard back from Yelp.
[2014-02-02 21:35:26 UTC] ddp wrote:
I updated tests/run.scm to only run if it can find a '../../ywsid.scm' file in the local root. This effectively nukes the tests for everyone else but it should fix the nightly salmonella in the trunk (and preserves my ability to run the tests).