Summary
sendfile test errors
Metadata
- Id: 8540f2af93712bfff1d793e5500e9b7322e5ad97
- Trac id: 729
- Type: defect
- Reporter: mario
- Owner: certainty
- Cc:
- Status: closed
- Component: extensions
- Estimated difficulty:
- Resolution: fixed
- Priority: critical
- Milestone: 4.9.0
- Version: 4.7.x
- Changetime: 2012-09-24 21:47:48 UTC
- Created: 2011-11-17 18:39:25 UTC
- Keywords: sendfile
Attachments
- 8540f2af93712bfff1d793e5500e9b7322e5ad97/attachments/729-osx.patch
Description
sendfile's test suite shows errors on different platforms:
* linux/x86 (chicken 4.7.0.3-st): http://paste.call-cc.org/paste?id=75b3ffa3059d572fadd4fb49b094868dc9828871 * linux/x86-64 (chicken 4.7.0): http://paste.call-cc.org/paste?id=75b3ffa3059d572fadd4fb49b094868dc9828871#a1 * macoxs/x86-64 (master branch): http://tests.call-cc.org/master/macosx/x86_64/2011/11/14/salmonella-report/test/sendfile.html * linux/x86 (master branch): http://tests.call-cc.org/master/linux/x86/2011/11/17/salmonella-report/tests/sendfile.html
Changes and comments
[2011-11-17 18:49:07 UTC] zbigniew wrote:
Also, sending a file on macosx 64-bit 10.7 with sendfile results in corruption at byte 81661 (I have also seen 83K).
[2011-11-17 19:31:18 UTC] zbigniew wrote:
I believe the problem on OS X is that sendfile() will return EAGAIN even if it was able to send partial data; this is then discarded by the implementation, which assumes zero bytes were sent and tries to retransmit the full buffer.
[2011-11-17 20:00:06 UTC] zbigniew changed priority from major to critical
[2011-11-17 20:00:06 UTC] zbigniew wrote:
This patch fixes the corruption on OS X. Use `hg import` to import it, I do not feel like forking on bitbucket so sue me lolololol
[2011-11-17 20:00:38 UTC] zbigniew attached 729-osx.patch (description=Fix corruption on OS X related to EAGAIN)
[2011-11-18 18:39:34 UTC] certainty changed status from new to accepted
[2011-11-18 18:39:34 UTC] certainty wrote:
Thanks for reporting this, Jim. There are some tests which fail occasionally as well. I don't know why yet. I'll happily apply your patch
[2011-11-19 07:18:09 UTC] certainty changed status from accepted to closed
[2011-11-19 07:18:09 UTC] certainty set resolution to fixed
[2011-11-19 07:18:09 UTC] certainty wrote:
I've applied the patch to trunk and will soon tag a release
[2012-09-24 21:47:48 UTC] felix changed milestone from 4.8.0 to 4.9.0
[2012-09-24 21:47:48 UTC] felix wrote:
Milestone 4.8.0 deleted