Summary
Ports don't keep track of "column" anymore - restore this
Metadata
- Id: 53ead5c6703edc214a5a71c672661faf01056b58
- Trac id: 978
- Type: defect
- Reporter: sjamaan
- Owner: sjamaan
- Cc:
- Status: closed
- Component: core libraries
- Estimated difficulty:
- Resolution: fixed
- Priority: not urgent at all
- Milestone: someday
- Version: 4.8.x
- Changetime: 2013-11-03 12:50:25 UTC
- Created: 2013-02-07 13:31:28 UTC
- Keywords: ports, position
Attachments
- 53ead5c6703edc214a5a71c672661faf01056b58/attachments/0002-Also-add-column-row-counting-to-read-string.patch
Description
Slot 5 is no longer being updated by any port procedure except read-char. This causes port-position to return useless values.
This should be restored for read-line and friends.
Changes and comments
[2013-06-01 00:11:44 UTC] zbigniew changed priority from minor to not urgent at all
[2013-06-01 00:11:44 UTC] zbigniew changed milestone from 4.9.0 to someday
[2013-06-01 00:11:44 UTC] zbigniew wrote:
read-line is fixed in a302a6dcc9 per Peter's patch. I also added some tests for the affected ports.
I think we can leave read-string alone -- if you care about lines, you're probably using read-char or read-line anyway. I'm attaching Peter's read-string patch to the ticket for posterity, but I recommend we leave it alone until someone complains.
[2013-06-01 00:12:01 UTC] zbigniew attached 0002-Also-add-column-row-counting-to-read-string.patch (description=#f)
[2013-11-03 12:50:25 UTC] sjamaan changed status from new to closed
[2013-11-03 12:50:25 UTC] sjamaan set resolution to fixed
[2013-11-03 12:50:25 UTC] sjamaan wrote:
I think the fix for this ticket is acceptable. There's no reason to keep it open; the attached fix for read-string can hopefully be found when we need it, or else we can always write it again from scratch.