Summary

Wrong macro added to chicken-config.h in Makefile.cross-linux-mingw

Metadata

• Id: 532fe899f6dc818afea4c4cf020c670818a49bc7
• Trac id: 1768
• Type: defect
• Reporter: lattay
• Owner:
• Cc:
• Status: closed
• Component: build system
• Estimated difficulty: trivial
• Resolution: fixed
• Priority: minor
• Milestone: 5.3
• Version: 5.2.0
• Changetime: 2021-07-07 14:25:14 UTC
• Created: 2021-06-27 11:09:59 UTC
• Keywords:

Description

Hi, I noticed that there is a mistake in Makefile.cross-linux-mingw. In the process of creating chicken-config.h, this Makefile declares HAVE_ALLOCA_H when it should declare HAVE_ALLOCA only. Here is a "patch":

 diff --git a/Makefile.cross-linux-mingw b/Makefile.cross-linux-mingw
 index 929e140..6d6a690 100644
 --- a/Makefile.cross-linux-mingw
 +++ b/Makefile.cross-linux-mingw
 @@ -105,7 +105,7 @@ chicken-config.h: chicken-defaults.h
  	echo "#define HAVE_UNISTD_H 1" >>$@
  	echo "#define HAVE_UNSIGNED_LONG_LONG 1" >>$@
  	echo "#define STDC_HEADERS 1" >>$@
 -	echo "#define HAVE_ALLOCA_H 1" >>$@
 +	echo "#define HAVE_ALLOCA 1" >>$@
  	echo "#define HAVE_DIRECT_H 1" >>$@
  	echo "#define HAVE_ERRNO_H 1" >>$@
  	echo "#define HAVE_LOADLIBRARY 1" >>$@

Changes and comments

[2021-06-27 11:13:40 UTC] lattay wrote:

Just to be clear, the reason this is the right thing is the Win32 environment provides alloca in `malloc.h` which is included before the attempt to include `alloca.h`. Replying to lattay: > > Hi, > I noticed that there is a mistake in Makefile.cross-linux-mingw. > In the process of creating chicken-config.h, this Makefile declares HAVE_ALLOCA_H when it should declare HAVE_ALLOCA only. > Here is a "patch": > > { > diff --git a/Makefile.cross-linux-mingw b/Makefile.cross-linux-mingw > index 929e140..6d6a690 100644 > --- a/Makefile.cross-linux-mingw > +++ b/Makefile.cross-linux-mingw > @@ -105,7 +105,7 @@ chicken-config.h: chicken-defaults.h > echo "#define HAVE_UNISTD_H 1" >>$@ > echo "#define HAVE_UNSIGNED_LONG_LONG 1" >>$@ > echo "#define STDC_HEADERS 1" >>$@ > - echo "#define HAVE_ALLOCA_H 1" >>$@ > + echo "#define HAVE_ALLOCA 1" >>$@ > echo "#define HAVE_DIRECT_H 1" >>$@ > echo "#define HAVE_ERRNO_H 1" >>$@ > echo "#define HAVE_LOADLIBRARY 1" >>$@ > }

[2021-06-27 13:26:04 UTC] sjamaan changed milestone from someday to 5.3

[2021-07-07 14:25:14 UTC] sjamaan changed status from new to closed

[2021-07-07 14:25:14 UTC] sjamaan set resolution to fixed

[2021-07-07 14:25:14 UTC] sjamaan wrote:

Fixed in df3ecdfe37dc3e5d75663ad93bad9dab64e44d0e, thanks!