Summary

sendfile broken for files > 1MB

Metadata

• Id: 4bd3480dddbb32fc9d20839820307c603fa9aa3b
• Trac id: 727
• Type: defect
• Reporter: mario
• Owner: certainty
• Cc:
• Status: closed
• Component: extensions
• Estimated difficulty:
• Resolution: fixed
• Priority: critical
• Milestone: 4.9.0
• Version: 4.7.x
• Changetime: 2012-09-24 21:47:48 UTC
• Created: 2011-11-17 13:02:22 UTC
• Keywords: sendfile

Description

Here's the error when using spiffy to serve a file generated with

 dd if=/dev/zero of=foo.data bs=1024 count=1025

If the data file is generated with

 dd if=/dev/zero of=foo.data bs=1024 count=1024

no error occurs.

Moritz has provided a patch: http://moritz.twoticketsplease.de/files/excellent-sendfile-fix.patch which fixes that.

Changes and comments

[2011-11-18 18:33:57 UTC] certainty changed status from new to accepted

[2011-11-18 18:33:57 UTC] certainty wrote:

Thanks Moritz. That is a silly bug. I'll apply your patch asap

[2011-11-19 07:22:59 UTC] certainty changed status from accepted to closed

[2011-11-19 07:22:59 UTC] certainty set resolution to fixed

[2011-11-19 07:22:59 UTC] certainty wrote:

I've applied the patch and release 1.7.8. Thanks

[2012-09-24 21:47:48 UTC] felix changed milestone from 4.8.0 to 4.9.0

[2012-09-24 21:47:48 UTC] felix wrote:

Milestone 4.8.0 deleted