Summary
sendfile broken for chickens >= 4.6.0
Metadata
- Id: 23bcc724acfce746aecc2ef39b19133ea1e1152b
- Trac id: 361
- Type: defect
- Reporter: felix
- Owner: certainty
- Cc: sjamaan
- Status: closed
- Component: extensions
- Estimated difficulty:
- Resolution: fixed
- Priority: critical
- Milestone:
- Version: 4.6.x
- Changetime: 2010-08-28 13:15:07 UTC
- Created: 2010-08-27 19:04:54 UTC
- Keywords: sendfile
Attachments
- 23bcc724acfce746aecc2ef39b19133ea1e1152b/attachments/sendfile.diff
Description
Sendfile invokes (##sys#fudge 16), which isn't available anymore, and calls ##sys#thread-block-for-timeout! with invalid fixnum timeout values.
Changes and comments
[2010-08-27 19:11:48 UTC] sjamaan changed status from new to assigned
[2010-08-27 19:11:48 UTC] sjamaan set owner to certainty
[2010-08-27 19:11:48 UTC] sjamaan wrote:
I'll let David deal with this. By the way, what did (##sys#fudge 16) do?
[2010-08-27 20:07:09 UTC] felix wrote:
Replying to sjamaan: > I'll let David deal with this. By the way, what did (##sys#fudge 16) do?
(##sys#fudge 16) returns the current milliseconds since startup (now as flonum).
Attached is a patch, but I'm still fighting with a modified version of the scheduler, so I have done only very limited testing.
[2010-08-27 20:07:50 UTC] felix attached sendfile.diff (description=#f)
[2010-08-28 10:43:34 UTC] certainty changed status from assigned to closed
[2010-08-28 10:43:34 UTC] certainty set resolution to fixed
[2010-08-28 10:43:34 UTC] certainty wrote:
Thanks very much for the patch. I've applied it and released a new version. I probably should have looked for a away to avoid procedures out of the ##sys#-namespace where possible, before. :)
[2010-08-28 13:15:07 UTC] felix wrote:
Replying to certainty: > Thanks very much for the patch. > I've applied it and released a new version. > I probably should have looked for a away to avoid procedures out of the ##sys#-namespace where possible, before. :)
Have you tested it? I am not 100% sure this change works with pre 4.6.0 chickens!