Summary

srfi-19: time-monotonic->julian-day returns procedure, not value

Metadata

• Id: 2047458721f54c549ce70f7ce44c7674396c847f
• Trac id: 829
• Type: defect
• Reporter: sjamaan
• Owner: kon
• Cc:
• Status: closed
• Component: extensions
• Estimated difficulty:
• Resolution: fixed
• Priority: minor
• Milestone: 4.9.0
• Version: 4.7.x
• Changetime: 2012-05-13 16:08:02 UTC
• Created: 2012-05-13 11:51:47 UTC
• Keywords: srfi-19

Description

 #;1> (use srfi-19)
 #;2> (define t (current-time time-monotonic))
 #;3> (time-monotonic->julian-day t)
 #<procedure>
 #;4> (#3 t) ;; This is of course incorrect
 70734554131963/28800000

It looks like this is a small mistake which is simple to fix:

 Index: srfi-19-support.scm
 ===================================================================
 --- srfi-19-support.scm	(revision 26685)
 +++ srfi-19-support.scm	(working copy)
 @@ -1279,7 +1279,7 @@
    (let ((sec (%time-second tim)))
      (tm:seconds->julian-day (%time-nanosecond tim) (- sec (leap-second-delta sec))) ) )
  
 -(define (tm:time-monotonic->julian-day tim) tm:time-tai->julian-day)
 +(define tm:time-monotonic->julian-day tm:time-tai->julian-day)
  
  (define (tm:time->julian-day tim)
    (case (%time-type tim)

This bug was found by the scrutinizer, see http://tests.call-cc.org/master/linux/x86/2012/05/12/salmonella-report/install/srfi-19.html (search for the string "Warning:")

Changes and comments

[2012-05-13 16:08:02 UTC] kon changed status from new to closed

[2012-05-13 16:08:02 UTC] kon set resolution to fixed

[2012-05-13 16:08:02 UTC] kon wrote:

Rel 3.3.1