Summary

Should csc-options be valid at the top level too?

Metadata

• Id: 1a320e098126ce07791bb2b84abf1a50b98bf02d
• Trac id: 1484
• Type: enhancement
• Reporter: mario
• Owner:
• Cc:
• Status: closed
• Component: build system
• Estimated difficulty:
• Resolution: fixed
• Priority: not urgent at all
• Milestone: 5.0
• Version: 5.0.0
• Changetime: 2018-07-26 20:22:07 UTC
• Created: 2018-07-09 20:43:26 UTC
• Keywords: csc-options

Description

Currently, csc-options is not valid at the top level of .egg files. That leads to a lot of code duplication in case eggs declare multiple components.

How about allowing a top level csc-options declaration that can be clobbered by component-specific csc-options declarations?

Changes and comments

[2018-07-10 01:12:55 UTC] evhan wrote:

I think so, and link-options too.

[2018-07-24 12:02:01 UTC] evhan wrote:

I think common options for all components should go in a (component-options ...) item (or something similarly named), rather than at the top level of the egg file. We should probably still limit it to csc-options and link-options, though.

[2018-07-25 14:59:11 UTC] felix wrote:

I would suggest to make it cumulative - local options get added to toplevel options.

[2018-07-25 14:59:11 UTC] felix wrote:

1532523567088813

[2018-07-26 20:22:07 UTC] kooda changed status from new to closed

[2018-07-26 20:22:07 UTC] kooda set resolution to fixed

[2018-07-26 20:22:07 UTC] kooda wrote:

Fixed by 9b2b6bc717ed266f17721444e9ac4e6277aa0c01