Summary
ck-macros egg tests fail due to unknown ck-wrapper identifier
Metadata
- Id: 0fb3c6c9d0aeda5a55f83c947929e6cc6a1e615d
- Trac id: 1646
- Type: defect
- Reporter: sjamaan
- Owner:
- Cc:
- Status: closed
- Component: unknown
- Estimated difficulty: medium
- Resolution: duplicate
- Priority: major
- Milestone: 5.2
- Version: 5.1.0
- Changetime: 2019-10-06 16:07:59 UTC
- Created: 2019-08-26 10:15:44 UTC
- Keywords:
Description
I noticed in today's Salmonella run that the ck-macros egg no longer passes its tests.
This is probably caused by f43fb51ea3838cccd62b613cf82b3625809a9f93, but the question is whether this just exposes a pre-existing bug in the egg (which I consider quite likely, especially considering this is the only egg that broke) or if it's a regression.
Changes and comments
[2019-09-26 11:58:36 UTC] sjamaan wrote:
As I suspected, it's a bug in the egg. It included the file which provides `ck-wrapper` in a `begin-for-syntax` block. This is a helper procedure which is used by macros, but it is also exposed to the user. Because the module does an implicit export of everything via `*`, it only failed in the tests.
I submitted a merge|requested to fix this.
[2019-10-06 16:07:59 UTC] sjamaan changed status from new to closed
[2019-10-06 16:07:59 UTC] sjamaan set resolution to duplicate
[2019-10-06 16:07:59 UTC] sjamaan wrote:
Not a blocker for 5.2; this is a bug in the egg and I filed a merge request there so this doesn't have to clutter up our Trac.