Summary

'test -e' is not supported on Solaris sh

Metadata

• Id: 048d9db78047f4b70e2b0d8a90b72c1940234432
• Trac id: 965
• Type: defect
• Reporter: mikele
• Owner: mikele
• Cc:
• Status: closed
• Component: build system
• Estimated difficulty:
• Resolution: fixed
• Priority: minor
• Milestone: 4.9.0
• Version: 4.8.x
• Changetime: 2013-01-22 10:18:10 UTC
• Created: 2013-01-19 02:00:39 UTC
• Keywords:

Description

While building chicken on Solaris10, the script identify.sh failed because of 'test -e'. Suggested fix: use 'test -f'. Same job, more portable.

Changes and comments

[2013-01-19 02:13:49 UTC] zbigniew wrote:

Fix seems good, but I wonder why identity.sh is being invoked when building from a tarball -- the component files (buildbranch, etc.) should already exist. Is this expected?

I also wonder if all the variables (host, branchname0, etc.) should be moved inside the test for ".git", as they aren't used outside that test. If .git does not exist, the only effect that identity.sh can have is just "touch buildbranch".

[2013-01-22 05:39:43 UTC] zbigniew changed status from new to assigned

[2013-01-22 05:39:43 UTC] zbigniew set owner to mikele

[2013-01-22 05:39:43 UTC] zbigniew wrote:

Fixed in 689d41ed86, please close after verifying.

[2013-01-22 10:18:10 UTC] mikele changed status from assigned to closed

[2013-01-22 10:18:10 UTC] mikele set resolution to fixed