Test scripts that don't properly report exit status

[Mario Domenech Goulart]

The eggs listed bellow don't properly report their exit code to the test infrastructure.

Please, make them exit 0 when all tests pass or a non-zero value when one or more tests fail, so salmonella can properly indicate the tests status. Hint: for those using the ​test egg, you just need (test-exit) at the end of the test script.

If you test script relies on errors (or assert) to test egg features, you can assume it is ok (I'm sorry for the false alert), since on error the test script will exit 70 (which is ok for the test infrastructure).

I took a look at the last 20 lines of the run.scm files (or at the files they include/load) in the trunk dir for each egg (yeah, it's not exactly a pleasant work). If you don't intend to make a new release of your egg(s) to fix bugs or to add new features soon, please consider making a new release just to fix the tests, so we can have a more accurate idea about the shape of the set of eggs. Also consider that egg tests help to test the compiler too.

bindings
char-set-literals
condition-utils
contracts
couchdb
directory-utils
discount
dsssl-utils
elliptic-curves
err5rs-arithmetic
expand-full
fmt
format
kanren
lazy-ffi
list-utils
logpro
lookup-table
macosx
mailbox
mathh
modular-arithmetic
mw-core
mw
netstring
numspell
openal
operations
packedobjects
pandora
procedure-decoration
progress-indicators
remote-mailbox
ripemd
sassy
sexp-diff
sha2
snowdigest
specialized-io
srfi-101
srfi-19
srfi-25
srfi-27
srfi-42
srfi-45
stack
statistics
string-utils
sxml-templates
symbol-utils
synch
system
tigher-hash
tinyclos
tuples
uuid-ossp
xosd
yasos
yelp

[felix winkelmann]

I updated advice, ftl, udp, defstruct, simple-sha1 and coops.

The following eggs don't use test, use assert or perform just simple code execution examples:

big-chicken, bind, dollar, fast-generic, fps, heap-o-rama, htmlprag, inline, loop, protobj, s11n,
spock, sparse-vectors, stalin, z3.

[Matt Welland]

logpro updated with (test-exit)

[sjamaan]

Thank you for working through these things, Mario!

I've updated numbers (which is still not a great testsuite, but more-or-less works as expected now)

prometheus is also an egg that just uses assert and has a few examples.

I've removed these from the list as well as those Felix listed.

[Ivan Raikov]

Added test-exit for csv and digraph, and assert for datatype

[Ivan Raikov]

Removing mpi and memcached from the list, as their test scripts have been already fixed.

[Ivan Raikov]

Added test-exit to the test scripts of getopt-long and format-textdiff

[Ivan Raikov]

Added test-exit to the test scripts of filepath, graph-bfs, graph-dfs, graph-cycles

[Ivan Raikov]

Added test-exit to the test scripts for internet-message, graph-scc, iexpr

[Ivan Raikov]

Fixed test scripts of internet-message, lexgen, json-abnf, object-graph

[Ivan Raikov]

Fixed test scripts of mime, rb-tree, sfht, smtp.

[Ivan Raikov]

Using assert in treap, typeclass, tiny-prolog

[sjamaan]

coops-utils has been modified in the meanwhile, it appears: ​http://tests.call-cc.org/master/linux/x86/2012/05/08/salmonella-report/test/coops-utils.html

[sjamaan]

quaternoins has a hand-rolled test system which calls "error" when a test fails; this should cause exit status 1