Opened 5 years ago

Closed 5 years ago

#1150 closed defect (fixed)

irc: tcp-read-timeout not paramaterized everywhere that it needs to be

Reported by: acharlton Owned by: felix winkelmann
Priority: minor Milestone: someday
Component: extensions Version: 4.9.x
Keywords: irc Cc:
Estimated difficulty:

Description

The parameter tcp-read-timeout is correctly set to irc:connection-reconnect-timeout in irc:connect, but it isn’t elsewhere. Notably, the procedure read-input, which calls read-line, should have a parametrization of tcp-read-timeout. Otherwise, the read-line times-out after the tcp default of one minute which is quite a bit shorter than desirable (the default irc:connection-reconnect-timout is one hour).

read-input should be the only (additional) location where tcp-read-timout must be set. Higher level procedures (irc:listen, irc:run-message-loop) all read the input port through this procedure. The attached patch does this.

Attachments (1)

irc.patch (727 bytes) - added by acharlton 5 years ago.

Download all attachments as: .zip

Change History (2)

Changed 5 years ago by acharlton

Attachment: irc.patch added

comment:1 Changed 5 years ago by felix winkelmann

Resolution: fixed
Status: newclosed

Should be fixed in 1.9.8.

Note: See TracTickets for help on using tickets.