Changeset 39737 in project

Timestamp:

03/18/21 16:17:06 (5 weeks ago)

Author:

Kon Lovett

Message:

has srfi-1 dep, fix seq-utils sort (was side-effecting arg)

Location:

release/5/micro-stats/trunk

Files:

• micro-stats.egg (modified) (1 diff)
• micro-stats.scm (modified) (1 diff)
• seq-utils.scm (modified) (2 diffs)
• tests/micro-stats-test.scm (modified) (1 diff)

release/5/micro-stats/trunk/micro-stats.egg

@@ -1 @@
-((synopsis "easily create micro-stats")
- (version "0.0.2")
+((synopsis "Easily create micro-stats")
+ (version "0.0.3")
  (author "David Krentzlin")
- (maintainer "[[kon lovett]]")
+ (maintainer "Kon Lovett")
  (category math)
  (license "GPLv3")
- (dependencies sequences)
+ (dependencies srfi-1 sequences)
  (test-dependencies test)
  (components

release/5/micro-stats/trunk/micro-stats.scm

@@ -22 +22 @@
   (chicken flonum)
   (chicken foreign)
-  (only (srfi 1) first append! list-copy)
+  (only (srfi 1) first list-copy)
   (prefix sequences seq:)
   (prefix seq-utils seq*:))

release/5/micro-stats/trunk/seq-utils.scm

@@ -15 +15 @@
   (chicken base)
   (chicken type)
+  (only (srfi 1) list-copy)
   (prefix (chicken sort) chicken:)
   (prefix sequences seq:))
@@ -57 +58 @@
 
 (define (sort seq less?)
-  (seq:coerce seq (chicken:sort! (seq->list seq) less?)) )
+  (define (*seq->list x) (if (list? x) (list-copy x) (seq:coerce *empty-list* x)))
+  (seq:coerce seq (chicken:sort! (*seq->list seq) less?)) )
 
 ;;

release/5/micro-stats/trunk/tests/micro-stats-test.scm

@@ -22 +22 @@
   (test "Performs Sort!" R1 (sort! V1 <))
   (test-assert "And Source is Sorted" (sorted? V1 <))
+)
+
+;sort was side-effecting a list arg
+(test-group "sort bug"
+  (define R1L '(1 2 3 4 5 6 7 8 9))
+  (define V1L '(5 3 4 2 1 9 7 8 6))
+  (test "Performs Sort" R1L (sort V1L <))
+  (test-assert "And Source is Unsorted" (not (sorted? V1L <)))
+  (test "Performs Sort!" R1L (sort! V1L <))
+  (test-assert "And Source is Sorted" (sorted? V1L <))
 )