Changeset 22133 in project

Timestamp:

12/26/10 22:06:59 (10 years ago)

Author:

sjamaan

Message:

Document new cookie behaviour (which is still horrible)

File:

• wiki/eggref/4/http-client (modified) (2 diffs)

wiki/eggref/4/http-client

@@ -173 +173 @@
 put in a {{cookie}} header.
 
-<procedure>(store-cookie! cookie)</procedure>
-
-Store the given {{cookie}} object in the cookiejar.  This overwrites
-any cookie that is equal to this cookie, as defined by RFC 2965,
-section 3.3.3.  Practically, this means that when the cookie's name,
-domain and path are equal to an existant one, it will be overwritten
-by the new one.
-
-<procedure>(delete-cookie! cookie)</procedure>
+<procedure>(store-cookie! cookie-info set-cookie)</procedure>
+
+Store a cookie in the cookiejar corresponding to the Set-Cookie header
+given by {{set-cookie}}.  This overwrites any cookie that is equal to
+this cookie, as defined by RFC 2965, section 3.3.3.  Practically, this
+means that when the cookie's name, domain and path are equal to an
+existant one, it will be overwritten by the new one.  These attributes
+are taken from the {{cookie-info}} alist and expected to be there.
+
+Generally, attributes should be taken from {{set-cookie}}, but if
+missing they ought to be taken from the request URI that responded
+with the {{set-cookie}}.
+
+<procedure>(delete-cookie! cookie-name cookie-info)</procedure>
 
 Removes any cookie from the cookiejar that is equal to the given
-{{cookie}} (again, in the sense of RFC 2965, section 3.3.3).
+cookie (again, in the sense of RFC 2965, section 3.3.3).
+The {{cookie-name}} must match and the {{path}} and {{domain}} values for
+the {{cookie-info}} alist must match.
 
 ==== Authentication support
@@ -264 +271 @@
 === Changelog
 
-* trunk Fixed handling of missing Path parameters in set-cookie headers. Reported by Hugo Arregui.
+* 0.3 Fixed handling of missing Path parameters in set-cookie headers. Reported by Hugo Arregui. Improve set-cookie handling by only passing Path and Domain when matching Set-Cookie header included those parameters.
 * 0.2 Added proxy support and many many bugfixes
 * 0.1 Initial version