Changeset 21138 in project for demonstrations

Timestamp:

10/30/10 19:47:15 (10 years ago)

Author:

Mario Domenech Goulart

Message:

demonstrations/awful/fortune: bug fix and improved `random-fortune' (excellent tips from Peter Bex)

Location:

demonstrations/awful/fortune

Files:

• create-database.scm (modified) (1 diff)
• fortune-server.scm (modified) (1 diff)

demonstrations/awful/fortune/create-database.scm

@@ -127 +127 @@
 
 (let ((db (open-database "fortunes.db")))
-  (exec (sql db "create table fortunes(id integer primary key autoincrement, sentence text, author text)"))
+  (exec (sql db "create table fortunes(sentence text, author text)"))
   (for-each (lambda (fortune)
               (let* ((sentence (car fortune))

demonstrations/awful/fortune/fortune-server.scm

@@ -6 +6 @@
 (db-credentials "fortunes.db")
 
-(define random-fortune
-  (let ((num-fortunes #f))
-    (lambda ()
-      (unless num-fortunes
-        (set! num-fortunes (caar ($db "select count(id) from fortunes"))))
-      (car ($db (conc "select sentence, author from fortunes where id="
-                      (random num-fortunes)))))))
+(define (random-fortune)
+  (car ($db "select sentence, author from fortunes order by random() limit 1")))
 
 (define-page (main-page-path)